Tried to merge alle changes and i18n for the Ooos#9
Open
Sumidu wants to merge 19 commits intodrewish:mainfrom
Open
Tried to merge alle changes and i18n for the Ooos#9Sumidu wants to merge 19 commits intodrewish:mainfrom
Sumidu wants to merge 19 commits intodrewish:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since you liked the one page OOO style and I like the other style I have added a variable in config.rb to switch between both versions.
I hope this is ok. I don't think this is the optimal implementation as I simply do if else switches.
But I haven't figured out how to store and manipulate symbols (e.g., ":right" ) in variables, yet. :)